Skip to content

[codex] Fix desktop secret CLI output#630

Merged
winhowes merged 3 commits intomainfrom
codex/fix-desktop-secret-store-output
Apr 21, 2026
Merged

[codex] Fix desktop secret CLI output#630
winhowes merged 3 commits intomainfrom
codex/fix-desktop-secret-store-output

Conversation

@winhowes
Copy link
Copy Markdown
Owner

Motivation

  • Auditing the newly merged desktop OS secret backends showed that the CLI-backed stores return stdout line terminators with the secret value.
  • security find-generic-password -w on macOS was verified locally with a temporary Keychain item and returned the stored value followed by 0a.
  • Passing that terminator through to auth plugins can make header-based outgoing credentials invalid.

Description

  • Trim a single LF or CRLF command-output terminator from macOS Keychain and Linux Secret Service plugin results.
  • Preserve surrounding whitespace and all other secret content.
  • Keep the Windows Credential Manager implementation unchanged after code review and Windows package compile validation.
  • Update the Redis TLS tests to generate 2048-bit RSA keys so the full suite passes under the repository-pinned Go toolchain.

Testing

  • go test ./app/secrets/...
  • GOOS=windows GOARCH=amd64 go test -c -o /tmp/authtranslator-wincred.test.exe ./app/secrets/plugins/wincred
  • GOTOOLCHAIN=go1.24.3 go test ./app -run 'TestRateLimiterRedisTLS(AuthRequiresVerification|WithCA)' -count=1
  • go vet ./...
  • test -z "$(git ls-files '*.go' | xargs gofmt -l)"
  • GOTOOLCHAIN=go1.24.3 go test ./...

Codex Task

@winhowes winhowes marked this pull request as ready for review April 21, 2026 17:03
@winhowes
Copy link
Copy Markdown
Owner Author

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8fef3caad8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread app/secrets/plugins/secretservice/plugin.go Outdated
Copy link
Copy Markdown
Owner Author

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 01af065719

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread app/secrets/plugins/keychain/plugin.go Outdated
Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@winhowes winhowes merged commit bbeb0bd into main Apr 21, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant